On Sat, Mar 05, 2011 at 07:35:39PM +0100, Johannes Berg wrote: > From: Johannes Berg <johannes.berg@xxxxxxxxx> > > In the case where remain-on-channel rather than > offchannel TX should be used, my offchannel TX > patch introduced a bug because mac80211 will > use the now-freed SKB. > > iwlagn shouldn't free the SKB when it returns 1 > here since then the SKB will still be used. > > Reported-by: Reinette Chatre <reinette.chatre@xxxxxxxxx> > Signed-off-by: Johannes Berg <johannes.berg@xxxxxxxxx> > --- > drivers/net/wireless/iwlwifi/iwl-agn.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- a/drivers/net/wireless/iwlwifi/iwl-agn.c 2011-03-05 19:32:58.000000000 +0100 > +++ b/drivers/net/wireless/iwlwifi/iwl-agn.c 2011-03-05 19:33:08.000000000 +0100 > @@ -3171,7 +3171,7 @@ static int iwl_mac_offchannel_tx(struct > out: > mutex_unlock(&priv->mutex); > free: > - if (ret) > + if (ret < 0) > kfree_skb(skb); > > return ret; OK, I give-up...what tree is this against? :-) -- John W. Linville Someday the world will need a hero, and you linville@xxxxxxxxxxxxx might be all we have. Be ready. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
