On Mon, 2011-03-07 at 15:22 +0100, Stanislaw Gruszka wrote: > On Mon, Mar 07, 2011 at 02:14:53PM +0100, Johannes Berg wrote: > > on_oper_chan = ieee80211_cfg_on_oper_channel(local); > > > > WARN_ON(local->scanning & (SCAN_SW_SCANNING | SCAN_HW_SCANNING)); > Not needed, just zeroed local->scanning. Yeah, I realised that a few minutes ago too, thanks. > > @@ -332,7 +321,6 @@ static void __ieee80211_scan_completed_f > > } > > > > ieee80211_recalc_idle(local); > > - mutex_unlock(&local->mtx); > > > > ieee80211_mlme_notify_scan_completed(local); > > ieee80211_ibss_notify_scan_completed(local); > I'm a bit worried about calling these with mutex. Yeah so was I, but I audited them and they should be fine. mesh and mlme only do some rcu-based list iteration and start timers/workqueue items, and ibss does the same but grabs local->iflist_mtx -- however we don't hold that here and it's always taken after local->mtx. Thus it should be ok, right? johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
