On 2011-03-04 6:23 PM, Helmut Schaa wrote: > Am Freitag, 4. März 2011 schrieb Felix Fietkau: >> On 2011-03-04 1:31 PM, Helmut Schaa wrote: >> > Devices without multi rate retry support won't be able to use all rates >> > as specified by mintrel_ht. Hence, we can simply skip setting up further >> > rates as the devices will only use the first one. >> > >> > Signed-off-by: Helmut Schaa <helmut.schaa@xxxxxxxxxxxxxx> >> > --- >> > >> > has_mrr is true if the device is able to make use of at least four rates. Not >> > sure if we might want to consider further special cases for devices with for >> > example a maximum of two rates. >> I think we should add a special case for handling a maximum of two >> rates. Right now this is being used by brcm80211, so applying this patch >> might make things worse there. > > John, please drop this patch then. > > Felix, currently minstrel_ht uses a maximum of 3 rates as far as I can see. > > In the sampling case it's > sample_rate -> highest_tp_rate -> highest_prob_rate > and in the default case it's > highest_tp_rate -> second_highest_tp_rate -> highest_prob_rate > > For devices with just one possible rate it would be either the sample_rate > or the highest_tp_rate. > > And for devices with two rates it might make sense to change the logic to > something like > sample_rate -> highest_prob_rate > and > highest_tp_rate -> highest_prob_rate > > Does that sound reasonable? Yes, sounds good. - Felix -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
