--- On Tue, 1/3/11, Larry Finger <Larry.Finger@xxxxxxxxxxxx> wrote:
> The driver for the RTL8187L chips
> returns IEEE80211_TX_STAT_ACK for all
> packets, even if the maximum number of retries was
> exhausted. In addition
> it fails to setup max_rates in the ieee80211_hw struct,
> This behavior
> may be responsible for the problems noted in Bug 14168. As
> the bug is very
> old, testers have not been found, and I do not have the
> case where the
> indicated signal is less than -70 dBm.
>
> Signed-off-by: Larry Finger <Larry.Finger@xxxxxxxxxxxx>
> Cc: Stable <stable@xxxxxxxxxx>
> ---
>
> V1 => V2: Protect against zero divide, and the case
> where the 16-bit retry
> counter wraps to zero. The latter
> is unlikely, but tested for
> completeness.
Acked-by: Hin-Tak Leung <htl10@xxxxxxxxxxxxxxxxxxxxx>
This may be style-thing - the meaning of some of the variables changes mid-routine. I think one alternative way (not necessarily better) is to unlock the mutex and return if length ==0, and something similiar to the register wrap-around?
I'm okay with this as is though.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
