On 02/27/2011 08:21 PM, Hin-Tak Leung wrote:
--- On Sun, 27/2/11, Larry Finger<Larry.Finger@xxxxxxxxxxxx> wrote:
The driver for the RTL8187L chips
returns IEEE80211_TX_STAT_ACK for all
packets, even if the maximum number of retries was
exhausted. In addition
it fails to setup max_rates in the ieee80211_hw struct,
This behavior
may be responsible for the problems noted in Bug 14168. As
the bug is very
old, testers have not been found, and I do not have the
case where the
indicated signal is less than -70 dBm.
Possibility of division by zero? The while loop dequeues - does this code always get invoked with a non-empty queue? Also it worrys me a little if tmp< retry?
This routine is not schedules until a packet has been transmitted, thus the
queue length will always be at least one, but I should protect against a divide
by zero anyway.
The hardware keeps track of the retries. I suppose there could be a possibility
of the register wrapping back to zero. I'll throw in a test there as well.
Thanks,
Larry
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
