> -----Original Message-----
> The interrupt of the wl12xx is a level interrupt in nature, since the
> interrupt line is not auto-reset. However, since resetting the
> interrupt
> requires bus transactions, this cannot be done from an interrupt
> context. Thus, requesting a level interrupt would require to disable
> the
> irq and re-enable it after the HW is acknowledged. Since we now request
> a threaded irq, this can also be done by specifying the IRQF_ONESHOT
> flag.
>
> Triggering on an edge can be problematic in some platforms, if the
> sampling frequency is not sufficient for detecting very frequent
> interrupts. In case an interrupt is missed, the driver will hang as the
> interrupt line will stay high until it is acknowledged by the driver,
> which will never happen.
>
> Fix this by requesting a level triggered interrupt, with the
> IRQF_ONESHOT flag.
>
> Signed-off-by: Ido Yariv <ido@xxxxxxxxxx>
> ---
> drivers/net/wireless/wl12xx/sdio.c | 2 +-
> drivers/net/wireless/wl12xx/spi.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/wl12xx/sdio.c
> b/drivers/net/wireless/wl12xx/sdio.c
> index 7ee9d29..a4f6417 100644
> --- a/drivers/net/wireless/wl12xx/sdio.c
> +++ b/drivers/net/wireless/wl12xx/sdio.c
> @@ -229,7 +229,7 @@ static int __devinit wl1271_probe(struct sdio_func
> *func,
> wl->ref_clock = wlan_data->board_ref_clock;
>
> ret = request_threaded_irq(wl->irq, wl1271_hardirq, wl1271_irq,
> - IRQF_TRIGGER_RISING,
> + IRQF_TRIGGER_HIGH | IRQF_ONESHOT,
> DRIVER_NAME, wl);
> if (ret < 0) {
> wl1271_error("request_irq() failed: %d", ret);
> diff --git a/drivers/net/wireless/wl12xx/spi.c
> b/drivers/net/wireless/wl12xx/spi.c
> index df5a00f..18cf017 100644
> --- a/drivers/net/wireless/wl12xx/spi.c
> +++ b/drivers/net/wireless/wl12xx/spi.c
> @@ -409,7 +409,7 @@ static int __devinit wl1271_probe(struct spi_device
> *spi)
> }
>
> ret = request_threaded_irq(wl->irq, wl1271_hardirq, wl1271_irq,
> - IRQF_TRIGGER_RISING,
> + IRQF_TRIGGER_HIGH | IRQF_ONESHOT,
> DRIVER_NAME, wl);
> if (ret < 0) {
> wl1271_error("request_irq() failed: %d", ret);
> --
> 1.7.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-
> wireless" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
Ack for TI OMAP on all flavors
Benzy Gabay
Texas Instruments
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
