Search Linux Wireless

Re: [PATCH] at76c50x-usb: fix warning caused by at76_mac80211_tx now returning void

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2011-02-25 at 15:40 -0500, John W. Linville wrote:
> CC [M]  drivers/net/wireless/at76c50x-usb.o
> drivers/net/wireless/at76c50x-usb.c: In function âat76_mac80211_txâ:
> drivers/net/wireless/at76c50x-usb.c:1759:4: warning: âreturnâ with a value, in function returning void
> 
> This is fallout from commit 7bb4568372856688bc070917265bce0b88bb7d4d
> ("mac80211: make tx() operation return void").
> 
> Signed-off-by: John W. Linville <linville@xxxxxxxxxxxxx>
> ---
>  drivers/net/wireless/at76c50x-usb.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/wireless/at76c50x-usb.c b/drivers/net/wireless/at76c50x-usb.c
> index 10b4393..a37c93b 100644
> --- a/drivers/net/wireless/at76c50x-usb.c
> +++ b/drivers/net/wireless/at76c50x-usb.c
> @@ -1756,7 +1756,6 @@ static void at76_mac80211_tx(struct ieee80211_hw *hw, struct sk_buff *skb)
>  		if (compare_ether_addr(priv->bssid, mgmt->bssid)) {
>  			memcpy(priv->bssid, mgmt->bssid, ETH_ALEN);
>  			ieee80211_queue_work(hw, &priv->work_join_bssid);
> -			return NETDEV_TX_BUSY;

I guess I missed this one -- bit it needs to free the SKB otherwise it
probably leaks.

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux