Hi Johannes, > -----Original Message----- > From: linux-wireless-owner@xxxxxxxxxxxxxxx [mailto:linux-wireless-owner@xxxxxxxxxxxxxxx] On Behalf Of > Johannes Berg > Sent: Wednesday, February 23, 2011 12:24 AM > To: Bing Zhao > Cc: linux-wireless@xxxxxxxxxxxxxxx; John W. Linville; Dan Williams; David Woodhouse; Amitkumar Karwar; > Kiran Divekar; Frank Huang; Greg KH; David S. Miller > Subject: RE: [PATCH 00/31] wireless: Marvell mwifiex driver for SD8787 > > On Tue, 2011-02-22 at 19:37 -0800, Bing Zhao wrote: > > > Is it OK if I change PRINTM (debugging printk) to something like IWL_DEBUG_? > > > > <drivers/net/wireless/iwlwifi/iwl-debug.h> > > ...... > > #define IWL_DEBUG_INFO(p, f, a...) IWL_DEBUG(p, IWL_DL_INFO, f, ## a) > > #define IWL_DEBUG_MAC80211(p, f, a...) IWL_DEBUG(p, IWL_DL_MAC80211, f, ## a) > > #define IWL_DEBUG_MACDUMP(p, f, a...) IWL_DEBUG(p, IWL_DL_MACDUMP, f, ## a) > > #define IWL_DEBUG_TEMP(p, f, a...) IWL_DEBUG(p, IWL_DL_TEMP, f, ## a) > > #define IWL_DEBUG_SCAN(p, f, a...) IWL_DEBUG(p, IWL_DL_SCAN, f, ## a) > > #define IWL_DEBUG_RX(p, f, a...) IWL_DEBUG(p, IWL_DL_RX, f, ## a) > > #define IWL_DEBUG_TX(p, f, a...) IWL_DEBUG(p, IWL_DL_TX, f, ## a) > > #define IWL_DEBUG_ISR(p, f, a...) IWL_DEBUG(p, IWL_DL_ISR, f, ## a) > > ...... > > > > Or, you want me to remove PRINTM stuff completely? > > Yeah, I know that's there in iwlwifi too ... I don't like it, but I > couldn't yet get it removed or replaced by newer infrastructure (which > didn't exist when this was written). Can I convince you to at least look > at pr_debug based things? Thanks for your suggestion. Yes, I will use pr_debug based API. Bing > > johannes > > -- > To unsubscribe from this list: send the line "unsubscribe linux-wireless" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html ÿô.nlj·Ÿ®‰†+%ŠË±é¥Šwÿº{.nlj·¥Š{±ÿ«zW¬³ø¡Ü}©ž²ÆzÚj:+v‰¨þø®w¥þŠàÞ¨è&¢)ß«a¶Úÿûz¹ÞúŽŠÝjÿŠwèf
