Search Linux Wireless

Re: [RFC/RFT] mac80211: make tx() operation return void

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Feb 15, 2011 at 6:10 PM, Johannes Berg
<johannes@xxxxxxxxxxxxxxxx> wrote:
> On Tue, 2011-02-15 at 19:06 +0200, Jussi Kivilinna wrote:
>
>> > -static int b43_op_tx(struct ieee80211_hw *hw,
>> > +static void b43_op_tx(struct ieee80211_hw *hw,
>> > Â Â Â Â Â Â Â Â Âstruct sk_buff *skb)
>> > Â{
>> > Â Â struct b43_wl *wl = hw_to_b43_wl(hw);
>> > @@ -3211,14 +3211,11 @@ static int b43_op_tx(struct ieee80211_hw
>> > Â Â if (unlikely(skb->len < 2 + 2 + 6)) {
>> > Â Â Â Â Â Â /* Too short, this can't be a valid frame. */
>> > Â Â Â Â Â Â dev_kfree_skb_any(skb);
>> > - Â Â Â Â Â return NETDEV_TX_OK;
>> > Â Â }
>>
>> Return missing.
>
> Right, thanks.
>
> johannes
>

Hi Johannes,

what about a v2 of this patch considering the b43 fix and recent ath5k
(needs a refresh) changes?

ath5k changes introduced by...

commit 12873372fe1f201813f1cc750a8af7d9193f445c
ath5k: move external function definitions to a header file

...in wireless-next-2.6

- Sedat -


[1] http://git.kernel.org/?p=linux/kernel/git/linville/wireless-next-2.6.git;a=commit;h=12873372fe1f201813f1cc750a8af7d9193f445c
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux