Hi, > On Fri, 2011-02-18 at 00:08 +0200, George Kashperko wrote: > > const struct ssb_bus_ops *ops; > > + const struct ssb_bus_helpers *helpers; > > Uhm, well. "helpers"... . Seems like a pretty generic term. > > I think this is still violating abstraction layering. Not as much > as your previous attempt, but still... > > You're putting the ops structure that is supposed to abstract > the ssb bus into the ssb_device data structure. That should ring a bell. > Reconsidered it already while arranging patches for Openwrt (the reason helpers were in device struct was to speedup access but these aint called often therefore they are in ssb_bus now). Also moved chipco.chipid into ssb_bus struct, could rename it also right away if only I get up fresh and with good idea how to name it properly or maybe you will suggest nice one. Have nice day, George -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
