On Fri, 2011-02-18 at 00:31 +0200, George Kashperko wrote: > +#define SSB_AI_BASE 0x18100000U /* base for AI registers */ #define MOON_EARTH_BASE 1337 That probably is my major point against this patchset. It just merges things that don't belong to each other. Is this the base on moon or earth? If it's the earth base, why the hell do we prefix the define with MOON? That naming confusion continues throughout the whole patchset. SSB is end of life, so we should not try to support the new AI hardware by making SSB AI aware. Just fork SSB and let legacy SSB die as the existing hardware dies. It deserves it. Mercy killing for software! _Currently_ it may look like a good idea to use one software base for the two busses, but the cruft will hurt you in the future. And the future begins one day after this hack was merged. -- Greetings Michael. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
