Search Linux Wireless

Re: [RFC/RFT] mac80211: make tx() operation return void

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 02/15/2011 08:07 AM, Johannes Berg wrote:
From: Johannes Berg<johannes.berg@xxxxxxxxx>

The return value of the tx operation is commonly
misused by drivers, leading to errors. All drivers
will drop frames if they fail to TX the frame, and
they must also properly manage the queues (if they
didn't, mac80211 would already warn).

Removing the ability for drivers to return a BUSY
value also allows significant cleanups of the TX
TX handling code in mac80211.

NB: Also fixes a bug in ath9k_htc.

Signed-off-by: Johannes Berg<johannes.berg@xxxxxxxxx>
---
  drivers/net/wireless/adm8211.c                |    4
  drivers/net/wireless/at76c50x-usb.c           |    7 -
  drivers/net/wireless/ath/ar9170/ar9170.h      |    2
  drivers/net/wireless/ath/ar9170/main.c        |    5
  drivers/net/wireless/ath/ath5k/base.c         |    5
  drivers/net/wireless/ath/ath5k/mac80211-ops.c |   10 -
  drivers/net/wireless/ath/ath9k/htc_drv_main.c |    7 -
  drivers/net/wireless/ath/ath9k/main.c         |    6
  drivers/net/wireless/ath/carl9170/carl9170.h  |    2
  drivers/net/wireless/ath/carl9170/tx.c        |    5
  drivers/net/wireless/b43/main.c               |    5
  drivers/net/wireless/b43legacy/main.c         |    5
  drivers/net/wireless/iwlwifi/iwl-agn.c        |    3
  drivers/net/wireless/iwlwifi/iwl-agn.h        |    2
  drivers/net/wireless/iwlwifi/iwl3945-base.c   |    3
  drivers/net/wireless/libertas_tf/main.c       |    3
  drivers/net/wireless/mac80211_hwsim.c         |    5
  drivers/net/wireless/mwl8k.c                  |   15 --
  drivers/net/wireless/p54/lmac.h               |    2
  drivers/net/wireless/p54/main.c               |    2
  drivers/net/wireless/p54/txrx.c               |   11 -
  drivers/net/wireless/rt2x00/rt2x00.h          |    2
  drivers/net/wireless/rt2x00/rt2x00mac.c       |    5
  drivers/net/wireless/rtl818x/rtl8180/dev.c    |    8 -
  drivers/net/wireless/rtl818x/rtl8187/dev.c    |    6
  drivers/net/wireless/rtlwifi/core.c           |    5
  drivers/net/wireless/wl1251/main.c            |    4
  drivers/net/wireless/wl12xx/main.c            |    4
  drivers/net/wireless/zd1211rw/zd_mac.c        |    5
  include/net/mac80211.h                        |    2
  net/mac80211/driver-ops.h                     |    4
  net/mac80211/tx.c                             |  164 ++++++++------------------
  32 files changed, 113 insertions(+), 205 deletions(-)

ACK for b43legacy, rtl8187, and rtlwifi.

Larry

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux