Search Linux Wireless

Re: [PATCH 1/2] cfg80211: add a field for the bitrate of the last rx data packet from a station

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Feb 15, 2011 at 12:55 AM, Johannes Berg
<johannes@xxxxxxxxxxxxxxxx> wrote:
> On Mon, 2011-02-14 at 23:08 -0800, Luis R. Rodriguez wrote:
>> On Mon, Feb 14, 2011 at 2:06 AM, Johannes Berg
>> <johannes@xxxxxxxxxxxxxxxx> wrote:
>> > On Thu, 2011-02-10 at 16:29 +0100, Felix Fietkau wrote:
>> >> Also fix a typo in the STATION_INFO_TX_BITRATE description
>> >>
>> >> Signed-off-by: Felix Fietkau <nbd@xxxxxxxxxxx>
>> >> ---
>> >> Âinclude/linux/nl80211.h | Â Â3 ++
>> >> Âinclude/net/cfg80211.h Â| Â Â5 +++-
>> >> Ânet/wireless/nl80211.c Â| Â 56 +++++++++++++++++++++++++++++++----------------
>> >> Â3 files changed, 44 insertions(+), 20 deletions(-)
>> >>
>> >> diff --git a/include/linux/nl80211.h b/include/linux/nl80211.h
>> >> index 821ffb9..35bfec2 100644
>> >> --- a/include/linux/nl80211.h
>> >> +++ b/include/linux/nl80211.h
>> >> @@ -1243,6 +1243,8 @@ enum nl80211_rate_info {
>> >> Â * @NL80211_STA_INFO_LLID: the station's mesh LLID
>> >> Â * @NL80211_STA_INFO_PLID: the station's mesh PLID
>> >> Â * @NL80211_STA_INFO_PLINK_STATE: peer link state for the station
>> >> + * @NL80211_STA_INFO_RX_BITRATE: last unicast rx rate, nested attribute
>> >> + * Â containing info as possible, see &enum nl80211_sta_info_txrate.
>> >
>> > I think it would make sense to restrict this to data frames, as mgmt
>> > frames will often be sent with a low rate.
>>
>> Would it be useful to show both? How about per AC?
>
> Why would anyone care about mgmt frames unless they're debugging
> something (in which case I recommend monitor interface)?

I was thinking enhancing/debugging multicast traffic.

> And normally
> rate control shouldn't care about the AC so that seems pointless?

Again, this would just informational. But sure, mon0 works too.

 Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux