On 02/15/2011 08:09 PM, Nikolay Ledovskikh wrote:
> This patch fixes seqfault on ar2316 and other AHB based chips.
You need to spare few more words on the changelog.
> Signed-off-by: Nikolay Ledovskikh <nledovskikh@xxxxxxxxx>
> ---
> diff --git a/drivers/net/wireless/ath/ath5k/ahb.c b/drivers/net/wireless/ath/ath5k/ahb.c
> index 707cde1..35d5273 100644
> --- a/drivers/net/wireless/ath/ath5k/ahb.c
> +++ b/drivers/net/wireless/ath/ath5k/ahb.c
...
> @@ -92,7 +92,7 @@ static int ath_ahb_probe(struct platform_device *pdev)
> goto err_out;
> }
>
> - mem = ioremap_nocache(res->start, res->end - res->start + 1);
> + mem = res->start;
Looking into the code which fills this, I still don't get the change.
res->start is a physical address which should be remapped. Care to
elaborate?
> if (mem == NULL) {
> dev_err(&pdev->dev, "ioremap failed\n");
> ret = -ENOMEM;
> @@ -114,10 +114,11 @@ static int ath_ahb_probe(struct platform_device *pdev)
> ret = -ENOMEM;
> goto err_out;
> }
> + SET_IEEE80211_DEV(hw, &pdev->dev);
>
> sc = hw->priv;
> sc->hw = hw;
> - sc->dev = &pdev->dev;
> + sc->dev = NULL;
This I don't understand too. Maybe because of missing changelog...
regards,
--
js
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
