On Tue, Feb 15, 2011 at 02:29:13PM +0000, ÐÐÐÐÐÐÐ ÐÐÐÐÐÑÐÐÑ wrote: > This patch fixes seqfault on ar2316 and other AHB based chips. Ok, but I'm guessing it also breaks PCI functionality? > struct ath5k_softc *sc = common->priv; > - struct platform_device *pdev = to_platform_device(sc->dev); > + struct platform_device *pdev = > to_platform_device(wiphy_dev(sc->hw->wiphy)); Your patch got wrapped strangely here... > - mem = ioremap_nocache(res->start, res->end - res->start + 1); > + mem = res->start; Won't this break iommu platforms? > + SET_IEEE80211_DEV(hw, &pdev->dev); > > - sc->dev = &pdev->dev; > + sc->dev = NULL; > /* Initialize driver private data */ > - SET_IEEE80211_DEV(hw, sc->dev); > @@ -216,6 +216,7 @@ ath5k_pci_probe(struct pci_dev *pdev, > ret = -ENOMEM; > goto err_map; > } > + SET_IEEE80211_DEV(hw, &pdev->dev); This set of changes needs some rationale... in other words, what is the real problem the patch fixes? -- Bob Copeland %% www.bobcopeland.com -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
