Search Linux Wireless

ath9k htc bug?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Johannes Berg wrote:
> This code in ath9k_ht_tx looks buggy:
> 
>         if (padsize && skb->len > padpos) {
>                 if (skb_headroom(skb) < padsize)
>                         return -1;
>                 skb_push(skb, padsize);
>                 memmove(skb->data, skb->data + padsize, padpos);
>         }
> 
> -1 isn't a valid netdev tx status code -- I think this should just be
> "goto fail_tx;" instead?

Yep, I have a fix lined up in my pending queue doing exactly that. :)

Sujith
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux