On Mon, Feb 14, 2011 at 12:31:00PM -0800, wwguy wrote: > On Mon, 2011-02-14 at 12:10 -0800, John W. Linville wrote: > > On Mon, Feb 14, 2011 at 07:57:33AM -0800, wwguy wrote: > > > On Mon, 2011-02-14 at 07:54 -0800, Johannes Berg wrote: > > > > On Mon, 2011-02-14 at 07:48 -0800, wwguy wrote: > > > > > On Mon, 2011-02-14 at 07:28 -0800, Johannes Berg wrote: > > > > > > On Mon, 2011-02-14 at 07:25 -0800, wwguy wrote: > > > > > > > On Mon, 2011-02-14 at 01:55 -0800, Johannes Berg wrote: > > > > > > > > On Thu, 2011-02-10 at 08:16 -0800, Wey-Yi Guy wrote: > > > > > > > > > remove plcp check for 3945, mark the function __maybe_unused > > > > > > > > > > > > > > > > Why not remove the function instead? > > > > > > > > > > > > > > > I guess we can remove it in legacy driver > > > > > > > > > > > > But it's a 3945 specific function, and never used, so ...?? > > > > > > > > > > > I mean we should remove this function in legacy driver after driver > > > > > split > > > > > > > > I just don't see why we can't remove it right now? > > > > > > > we can do it for _stable, for mainstream, all 3945 will move to separate > > > driver anyway. > > > > ...where it will still be unused. No? > > > we will remove it from our legacy driver I don't really see any reason to wait, so let's just remove it now. :-) John -- John W. Linville Someday the world will need a hero, and you linville@xxxxxxxxxxxxx might be all we have. Be ready. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html