> This patch isn't right. It fixes the oops but it introduces some leaks. > (We still need to release firmware that was allocated successfully). Sorry Dan, but where do you see the leaks? We make a call to wl_request_fw and if returns non-zero call wl_release_fw for a cleanup. I just removed the call to wl_release_fw in the wl_request_fw itself; so it should not introduce any leak. Could you pls clarify? -- Stas -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html