On 02/14/2011 11:20 AM, Johannes Berg wrote:
> I'm thinking this is [RFC] really?
>
>> @@ -1076,6 +1078,10 @@ enum nl80211_attrs {
>>
>> /* add attributes here, update the policy in nl80211.c */
>>
>> + NL80211_DFSEVENT_ATTR_FREQ,
>> + NL80211_DFSEVENT_ATTR_TS,
>> + NL80211_DFSEVENT_ATTR_WIDTH,
>
> I think it would be preferable to create a new DFS_EVENT attribute (also
> note that all attributse should be prefixed by NL80211_ATTR_) and then
> nest data into it.
>
> However, why is the TS/width data needed at all?
>
> johannes
>
Thanks for the review.
I will follow Your suggestions in case we decided to take the approach of
DFS handling done in userspace (we most probably will not).
FYI, TS and width are the attributes of radar pulse events that a DFS pattern
detector is fed with. In fact, the width is inaccurate (e.g. with Atheros
chipsets) for most test patterns, so you basically have a series of time
stamps to do the pattern matching.
Cheers
Zefir
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
