W dniu 9 lutego 2011 22:03 uÅytkownik George Kashperko
<george@xxxxxxxxxxx> napisaÅ:
>
> Ð ÐÑÐ, 09/02/2011 Ð 21:35 +0100, RafaÅ MiÅecki ÐÐÑÐÑ:
>> 2011/2/9 George Kashperko <george@xxxxxxxxxxx>:
>> > From: George Kashperko <george@xxxxxxxxxxx>
>> >
>> > Introduce handlers for SB core control and state flags' management. SB-style
>> > buses provide access to these flags at two high octets of TMSLOW and TMSHIGH
>> > registers whereas AI-ones implement these flags in two low octets of IOCTRL
>> > and IOSTAT registers.
>> > Signed-off-by: George Kashperko <george@xxxxxxxxxxx>
>> > ---
>> > Âdrivers/ssb/main.c   Â|  36 ++++++++++++++++++++++++++++++++++++
>> > Âinclude/linux/ssb/ssb.h | Â 14 +++++++++++++-
>> > Â2 files changed, 49 insertions(+), 1 deletion(-)
>> > --- linux-next-20110203.orig/drivers/ssb/main.c 2011-02-07 16:58:50.000000000 +0200
>> > +++ linux-next-20110203/drivers/ssb/main.c   Â2011-02-07 17:07:11.000000000 +0200
>> > @@ -1350,6 +1350,40 @@ static u32 ssb_admatch_size_sb(struct ss
>> > Â Â Â Âreturn size;
>> > Â}
>> >
>> > +static void ssb_core_ctl_flags_sb(struct ssb_device *dev, u32 mask,
>> > + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â u32 val, u32 *res)
>> > +{
>> > + Â Â Â u32 tmp;
>> > +
>> > + Â Â Â if (mask || val) {
>> > + Â Â Â Â Â Â Â tmp = (ssb_read32(dev, SSB_TMSLOW) & ~mask) | val;
>> > + Â Â Â Â Â Â Â ssb_write32(dev, SSB_TMSLOW, tmp);
>> > + Â Â Â }
>>
>> Are you going to use that function for just reading SSB_TMSLOW? Why
>> won't you use separated function then? Do you need separated function
>> for sth so simple as "ssb_read32(dev, SSB_TMSLOW);" at all?
> Will answer your question with another question ;)
> What would you personally prefer (press "1" or "2" :p)?
> 1)
> if (sb_bus)
> Â Â Â Âssb_write32(dev, (ssb_read32(dev, SSB_TMSLOW) & ~(mask << 16)) | (flags << 16));
> else
> Â Â Â Âssb_write32(dev, (ssb_read32(dev, SSB_AI_IOCTL) & ~mask) | flags));
> 2)
> ssb_core_ctl_flags(dev, mask, flags, NULL);
I aksed about reading, you gave me examples of writing. I want to
avoid such a non-readable disasters:
u32 tmp;
ssb_core_ctl_flags(dev, 0, 0, &tmp);
--
RafaÅ
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
