Switching general discussion to this thread.
W dniu 9 lutego 2011 22:12 uÅytkownik Michael BÃsch <mb@xxxxxxxxx> napisaÅ:
> On Wed, 2011-02-09 at 21:58 +0100, RafaÅ MiÅecki wrote:
>> I don't know, I've doubts about it :/ That flags are quite messy, mask
>> for them is 0x3FFC0000. Ideally we should shift it by 14 bits, but
>> that would make writing code harder. Maaaaybe... Michael what do you
>> think about this?
>
> I have no idea.
> I already expressed my opinion on all this stuff.
>
> One thing is for certain: If this is merged, George has to
> adopt maintainership.
What about proposed solution? Does it still look ugly for you with
that pointers to functions? It looks quite fine separated, similarly
to b43 and PHYs I think. Separated files and structs with pointers.
George: apart from few simple comparisons on beginning (like detecting
type of device and determining name in switch), do you need any more
(many?) tests in general code? Do you have many "if ssb_sb) {} else
{}"?
--
RafaÅ
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
