On Wednesday 09 February 2011 02:52 AM, Björn Smedman wrote:
On Mon, Feb 7, 2011 at 4:38 PM, Mohammed Shafi Shajakhan
<mshajakhan@xxxxxxxxxxx> wrote:
From: Mohammed Shafi Shajakhan<mshajakhan@xxxxxxxxxxx>
Add few comments for not parsing DTIM period from mac80211
Signed-off-by: Mohammed Shafi Shajakhan<mshajakhan@xxxxxxxxxxx>
---
drivers/net/wireless/ath/ath9k/beacon.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/ath/ath9k/beacon.c b/drivers/net/wireless/ath/ath9k/beacon.c
index 87ba44c..fcb36ab 100644
--- a/drivers/net/wireless/ath/ath9k/beacon.c
+++ b/drivers/net/wireless/ath/ath9k/beacon.c
@@ -721,8 +721,9 @@ void ath_beacon_config(struct ath_softc *sc, struct ieee80211_vif *vif)
cur_conf->beacon_interval = 100;
/*
- * Some times we dont parse dtim period from mac80211, in that case
- * use a default value
+ * We don't parse dtim period from mac80211 during the driver
+ * initialization as it breaks association with hidden-ssid
+ * AP and it causes latency in roaming
*/
if (cur_conf->dtim_period == 0)
cur_conf->dtim_period = 1;
I realize I'm not the perfect representative for the intended audience
but I don't understand that comment at all. The previous one made
sense to me, but the new one seems to refer to some logic somewhere
else. In ath_beacon_config() I expect AP/IBSS logic but the comment
seems to be about some special case for a STA vif associating with a
hidden access point, no? I don't understand that special case either
but that is more easily attributable to ignorance. :)
I also have don't have much idea. I saw that by parsing the DTIM
period(in init.c ,IEEE80211_HW_NEED_DTIM_PERIOD) from the mac80211 it
broke association with hidden-SSID AP .I shall dig deep into this in future.
thanks,
shafi
Best regards,
Björn
.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
