On Fri, Feb 4, 2011 at 19:12, Christian Lamparter <chunkeey@xxxxxxxxxxxxxx> wrote: > On Thursday 03 February 2011 23:39:40 Julian Calaby wrote: >> On Fri, Feb 4, 2011 at 08:30, Christian Lamparter >> <chunkeey@xxxxxxxxxxxxxx> wrote: >> > All AR9170 hardware have a 16-Bit random number generator. >> > The documentation claims the values are suitable for >> > "security keys". >> > >> > This is an early, but working version. The "throughput" is >> > around 320Kibit/s. It's slow, but it will work without >> > introducing any special offload firmware commands. >> >> Would it not be better to cut down on the #ifdefs and move this >> functionality into a separate file? > I don't think so. Just take a look at the led code, most of it is > in a separate file but the ifdefs are still everywhere you look... Fair enough. I was just thinking that if it were in a file, then the only bits that would need ifdef-ing would be one in a header file for the register_*() and unregister_*() exports and the Makefile. But then again, it's your driver =) Thanks, -- Julian Calaby Email: julian.calaby@xxxxxxxxx Profile: http://www.google.com/profiles/julian.calaby/ .Plan: http://sites.google.com/site/juliancalaby/ -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
