Search Linux Wireless

Re: [BUG] iwlwifi need to correct channels info

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2011-01-31 at 10:38 +0100, Stanislaw Gruszka wrote:

> > No, the above commit is buggy -- it assumes sband->band is set when it
> > isn't. 
> But it should be, no? It seems we initialize it nowhere, but it's
> used in iwl-*-rs.c

Yes, but it'll be set by cfg80211 when you register the wiphy as well.
This code is just special because it's before registration.

> BTW:
> Is iwl_eeprom_band_2[] array correct? It have 7, 8, 11, 12 channels entries
> on 5GHz.

Huh, not sure.

> Can we get rid of /* FIXME: might be removed if scan is OK */ ?

Not sure either.

> > Does this fix it?
> 
> I tested on 3945, it fix freq=0 on messages. But what about something
> slightly different? Use ch->band already set in iwl_init_channel_map()
> and initialize sband->band.

Sure, looks fine too.

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux