Hi Stanislaw,
On Fri, 2011-01-28 at 08:41 -0800, Stanislaw Gruszka wrote:
> On Fri, Jan 28, 2011 at 08:23:37AM -0800, wwguy wrote:
> > > -#ifdef CONFIG_IWLWIFI_DEBUG_EXPERIMENTAL_UCODE
> > > priv->fw_index = UCODE_EXPERIMENTAL_INDEX;
> > > strcpy(tag, UCODE_EXPERIMENTAL_TAG);
> > > } else if (priv->fw_index == UCODE_EXPERIMENTAL_INDEX) {
> > > -#endif
> > > priv->fw_index = priv->cfg->ucode_api_max;
> > > sprintf(tag, "%d", priv->fw_index);
> > > } else {
> >
> > The whole reason has it in Kconfig file is to have user not remove the
> > experimental uCode from /lib/firmware and not use it.
>
> What is easiest and less time consuming:
>
> this:
>
> $ mv /lib/firmware/iwlwifi-5000-exp.ucode /lib/firmware/iwlwifi-5000-exp.ucode.not_use
>
> or this:
>
> $ make menuconfig
> navigate to find option and edit it
> $ make modules
> $ make modules_install
>
> ?
>
> > Also put it in Kconfig file, so it is easy for user to see they are
> > using experimental option. Agree?
>
> Not really. I believe someone who download a tarball, unpack it and copy
> files to /lib/firmware is pretty much aware what he/she is doing.
>
Agree whoever download the tarball know what he/she is doing, but I am
not fully agree the driver always use experimental uCode if it is in the
firmware directory
Wey
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
