On Wed, 2011-01-26 at 09:31 +0100, ext Johannes Berg wrote: > On Wed, 2011-01-26 at 10:29 +0200, juuso.oikarinen@xxxxxxxxx wrote: > > From: Juuso Oikarinen <juuso.oikarinen@xxxxxxxxx> > > > > + IEEE80211_HW_SPECTRUM_MGMT; > > I once had a patch to remove this flag completely since it has very > little effect at all on mac80211. Can I convince you to review the flag > use in mac80211 and tell me why you think it is, or not, present? > > johannes Well I guess I'm stating the obvious here. The effects of the flag are: - It causes mac80211 to add the spectrum mgmt capability bit, list of supported channels and TX power capability info into the assoc-req - It causes mac80211 to process channel switch actions - It causes mac80211 to process and react to TPC power constraint elements sent out in beacons - It causes mac80211 to respond to TPC report requests by the AP, albeit currently only by refusing them. In addition to this, I plan to implement the TPC basic reporting, including mac80211 stuff if required (I still need to learn some more on the subject, specifically regarding the wl12xx chipset) and also I plan to implement quieting, though it's likely that wont need mac80211 intervention with wl12xx at least. AFAIK all these items are mandatory on the 5GHz band, at least in Europe. So I don't see how this flag could be removed. Unless you wan't to make the above default behavior - but then adding for instance the spectrum mgmt bit into the capabilities assumes all chipset will be able handle all of the features? -Juuso -Juuso -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
