On Wed, Jan 26, 2011 at 08:08, Arik Nemtsov <arik@xxxxxxxxxx> wrote: > On Tue, Jan 25, 2011 at 11:41, Jouni Malinen <j@xxxxx> wrote: >> On Mon, Jan 24, 2011 at 11:16:43PM +0200, Arik Nemtsov wrote: >>> The SSID-as-attr not used for the probe-resp template. It is used by >>> FW to filter out which probe-reqs should be responded to when >>> operating with a hidden SSID. >> >> OK, that would be useful to mention in nl80211.h comments and >> cfg80211.h, too, I'd guess. > > Sure. I'll put in a few words. > >> >>> The wl12xx FW updates the timestamp and DA. I mentioned in the >>> documentation of ieee80211_proberesp_get (and various other parts) >>> that the DA should be set manually and that this should be used as a >>> template (which also implies timestamp should be set). If some part is >>> unclear can you point out a specific patch? >> >> DA should be pretty obvious. Timestamp is something that I hope is clear >> for whoever is implementing a driver, but it could be mentioned >> somewhere. > > Sure. > >> >>> Perhaps we can start with these AP-mode only patches and expand the >>> functionality when it is needed for p2p? >> >> I'm fine with them if there is a capability flag that allows user space >> to know that the driver does not use user space -based Probe Request >> processing. With that, hostapd/wpa_supplicant can disable functionality >> like multi-SSID support, WPS 2.0, P2P until we get more complete >> capability information on what devices that process Probe Request frames >> internally can do. > > Makes sense. I'll look into it. > Just to clear up - I don't want to disable p2p or wps support in hostapd if probe-resp offloading is configured. The low level driver/fw could realistically differentiate between regular and non-support probe requests, and only handle the former. The kind of capability flag you asked won't work with such a low lever driver/fw combo. Is muti-ssid support currently implemented? How about a different solution - I'll just disable p2p IEs for the probe-resp template for now. Let's assume the FW behaves correctly in this case and passes up the probe-requests. The code for generating the WPS IE for the probe-resp seems to not depend on the probe-req. Is the feature of WPS 2.0 you mentioned currently implemented? If so this can be disabled as well. Arik -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
