On Tue, 2011-01-25 at 11:27 +0100, ext Johannes Berg wrote: > On Tue, 2011-01-25 at 12:21 +0200, juuso.oikarinen@xxxxxxxxx wrote: > > From: Juuso Oikarinen <juuso.oikarinen@xxxxxxxxx> > > > > Some vendor specific cipher suites require non-zero key indexes for pairwise > > keys, but as of currently, the cfg80211 does not allow it. > > Well, technically, that is incorrect -- just adding a vendor-specific > cipher to 802.11-2007 (11i) will uphold that requirement. Using > different mechanisms like WAPI might run afoul of this check... But > technically WAPI could also use CCMP etc. and then you might have to use > non-zero even for CCMP, so this code would again be wrong. I guess thats right. I was assuming this was for SMS-4 only, but I guess it extends to other ciphers too in association with WAPI. > OTOH, I don't really see a good way to capture this in code... I would be surprised to see WAPI used with CCMP though - or any other voluntary manner for that matter - although it is possible ;) So you think this patch is ok as is, or do I need to find some other way? -Juuso -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html