Search Linux Wireless

Re: [PATCH 2/2] ath5k: remove debug_dump_skb() functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2011/1/25 Bob Copeland <me@xxxxxxxxxxxxxxx>:
> Now that rx and tx dumps go through the tracing infrastructure,
> we no longer need to keep these routines around.
>
> Signed-off-by: Bob Copeland <me@xxxxxxxxxxxxxxx>
> ---
> Âdrivers/net/wireless/ath/ath5k/debug.c | Â 20 --------------------
> Âdrivers/net/wireless/ath/ath5k/debug.h | Â 10 ----------
> Â2 files changed, 0 insertions(+), 30 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath5k/debug.c b/drivers/net/wireless/ath/ath5k/debug.c
> index d2f84d7..0230f30 100644
> --- a/drivers/net/wireless/ath/ath5k/debug.c
> +++ b/drivers/net/wireless/ath/ath5k/debug.c
> @@ -308,8 +308,6 @@ static const struct {
> Â Â Â Â{ ATH5K_DEBUG_CALIBRATE, "calib", Â Â Â "periodic calibration" },
> Â Â Â Â{ ATH5K_DEBUG_TXPOWER, Â"txpower", Â Â Â"transmit power setting" },
> Â Â Â Â{ ATH5K_DEBUG_LED, Â Â Â"led", Â Â Â Â Â"LED management" },
> - Â Â Â { ATH5K_DEBUG_DUMP_RX, Â"dumprx", Â Â Â "print received skb content" },
> - Â Â Â { ATH5K_DEBUG_DUMP_TX, Â"dumptx", Â Â Â "print transmit skb content" },
> Â Â Â Â{ ATH5K_DEBUG_DUMPBANDS, "dumpbands", Â "dump bands" },
> Â Â Â Â{ ATH5K_DEBUG_DMA, Â Â Â"dma", Â Â Â Â Â"dma start/stop" },
> Â Â Â Â{ ATH5K_DEBUG_ANI, Â Â Â"ani", Â Â Â Â Â"adaptive noise immunity" },
> @@ -1036,24 +1034,6 @@ ath5k_debug_printrxbuffs(struct ath5k_softc *sc, struct ath5k_hw *ah)
> Â}
>
> Âvoid
> -ath5k_debug_dump_skb(struct ath5k_softc *sc,
> - Â Â Â Â Â Â Â Â Â Â Â struct sk_buff *skb, const char *prefix, int tx)
> -{
> - Â Â Â char buf[16];
> -
> - Â Â Â if (likely(!((tx && (sc->debug.level & ATH5K_DEBUG_DUMP_TX)) ||
> - Â Â Â Â Â Â Â Â Â Â(!tx && (sc->debug.level & ATH5K_DEBUG_DUMP_RX)))))
> - Â Â Â Â Â Â Â return;
> -
> - Â Â Â snprintf(buf, sizeof(buf), "%s %s", wiphy_name(sc->hw->wiphy), prefix);
> -
> - Â Â Â print_hex_dump_bytes(buf, DUMP_PREFIX_NONE, skb->data,
> - Â Â Â Â Â Â Â min(200U, skb->len));
> -
> - Â Â Â printk(KERN_DEBUG "\n");
> -}
> -
> -void
> Âath5k_debug_printtxbuf(struct ath5k_softc *sc, struct ath5k_buf *bf)
> Â{
> Â Â Â Âstruct ath5k_desc *ds = bf->desc;
> diff --git a/drivers/net/wireless/ath/ath5k/debug.h b/drivers/net/wireless/ath/ath5k/debug.h
> index 3e34428..b0355ae 100644
> --- a/drivers/net/wireless/ath/ath5k/debug.h
> +++ b/drivers/net/wireless/ath/ath5k/debug.h
> @@ -116,8 +116,6 @@ enum ath5k_debug_level {
> Â Â Â ÂATH5K_DEBUG_CALIBRATE Â = 0x00000020,
> Â Â Â ÂATH5K_DEBUG_TXPOWER Â Â = 0x00000040,
> Â Â Â ÂATH5K_DEBUG_LED Â Â Â Â = 0x00000080,
> - Â Â Â ATH5K_DEBUG_DUMP_RX Â Â = 0x00000100,
> - Â Â Â ATH5K_DEBUG_DUMP_TX Â Â = 0x00000200,
> Â Â Â ÂATH5K_DEBUG_DUMPBANDS Â = 0x00000400,
> Â Â Â ÂATH5K_DEBUG_DMA Â Â Â Â = 0x00000800,
> Â Â Â ÂATH5K_DEBUG_ANI Â Â Â Â = 0x00002000,
> @@ -152,10 +150,6 @@ void
> Âath5k_debug_dump_bands(struct ath5k_softc *sc);
>
> Âvoid
> -ath5k_debug_dump_skb(struct ath5k_softc *sc,
> - Â Â Â Â Â Â Â Â Â Â Â struct sk_buff *skb, const char *prefix, int tx);
> -
> -void
> Âath5k_debug_printtxbuf(struct ath5k_softc *sc, struct ath5k_buf *bf);
>
> Â#else /* no debugging */
> @@ -182,10 +176,6 @@ static inline void
> Âath5k_debug_dump_bands(struct ath5k_softc *sc) {}
>
> Âstatic inline void
> -ath5k_debug_dump_skb(struct ath5k_softc *sc,
> - Â Â Â Â Â Â Â Â Â Â Â struct sk_buff *skb, const char *prefix, int tx) {}
> -
> -static inline void
> Âath5k_debug_printtxbuf(struct ath5k_softc *sc, struct ath5k_buf *bf) {}
>
> Â#endif /* ifdef CONFIG_ATH5K_DEBUG */
> --
> 1.7.1.1
>

Acked-by: Nick Kossifidis <mickflemm@xxxxxxxxx>



-- 
GPG ID: 0xD21DB2DB
As you read this post global entropy rises. Have Fun ;-)
Nick
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux