This change doesn't regress the issue with scan-during-suspend. The other regression you should test for is that the system really does continue to honor powersave after a suspend-resume cycle (verify null-functions and drop in power consumption). You should be able to do that yourself, and I'd suggest testing for this case as well before committing any changes to powersave. -- Paul On Sat, Jan 22, 2011 at 11:21 PM, Rajkumar Manoharan <rmanoharan@xxxxxxxxxxx> wrote: > On Fri, Jan 21, 2011 at 04:32:20AM +0530, Luis R. Rodriguez wrote: >> On Wed, Jan 19, 2011 at 11:51 PM, Rajkumar Manoharan >> <rmanoharan@xxxxxxxxxxx> wrote: >> > On Thu, Jan 20, 2011 at 12:54:56AM +0530, Luis R. Rodriguez wrote: >> >> On Wed, Jan 19, 2011 at 7:47 AM, Rajkumar Manoharan >> >> <rmanoharan@xxxxxxxxxxx> wrote: >> >> > Upon unloading the driver, the ps_usecount is incremented >> >> > before configuring gpio registers in deinit_device. >> >> > But it is failed to restore the ps_usecount after that. >> >> > The problem is that the chip is moved to FULL SLEEP >> >> > by radio_disable when mac80211 is reporting as idle >> >> > though ps_usecount is not zero. >> >> > >> >> > This patch retores ps_usecount properly and ensures that >> >> > the chip is always moved to full sleep only if ps usage >> >> > counte is zero which helps in debugging. And also fixes >> >> > the following warning. >> >> > >> >> > ath: DMA failed to stop in 10 ms AR_CR=0xdeadbeef AR_DIAG_SW=0xdeadbeef >> >> > ath: Could not stop RX, we could be confusing the DMA engine when we >> >> > start RX up >> >> > ------------[ cut here ]------------ >> >> > WARNING: at drivers/net/wireless/ath/ath9k/recv.c:536 >> >> > ath_stoprecv+0xf4/0x100 [ath9k]() >> >> > >> >> >> >> Are you sure this hunk does not regress the suspend/resume case when >> >> using the new dbus API? >> >> >> > I verfied the suspend/resume case with AR9280 card. But I don't >> > understand how the new dbus API is related with this patch? >> >> Paul, if you get a chance to give this a spin before it gets merged >> it'd be appreciated. > Paul, > Did you get a chance to evaluate this patch? Shall we proceed further? > > -- > Rajkumar > -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
