RE: [PATCH] brcm80211: fix error report string

["Brett Rudley" <brudley@xxxxxxxxxxxx>]

> -----Original Message-----
> From: RafaÅ MiÅecki [mailto:zajec5@xxxxxxxxx]
> Sent: Monday, January 24, 2011 1:17 PM
> To: Gustavo F. Padovan
> Cc: Brett Rudley; Henry Ptasinski; Dowan Kim; vossen@xxxxxxxxxxxx; Arend
> Van Spriel; linux-wireless@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH] brcm80211: fix error report string
> 
> 2011/1/24 Gustavo F. Padovan <padovan@xxxxxxxxxxxxxx>:
> > Signed-off-by: Gustavo F. Padovan <padovan@xxxxxxxxxxxxxx>
> > ---
> > Âdrivers/staging/brcm80211/sys/wlc_mac80211.c | Â Â2 +-
> > Â1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/staging/brcm80211/sys/wlc_mac80211.c
> b/drivers/staging/brcm80211/sys/wlc_mac80211.c
> > index 5eb41d6..ee1bcc5 100644
> > --- a/drivers/staging/brcm80211/sys/wlc_mac80211.c
> > +++ b/drivers/staging/brcm80211/sys/wlc_mac80211.c
> > @@ -6910,7 +6910,7 @@ prep_mac80211_status(struct wlc_info *wlc,
> d11rxhdr_t *rxh, struct sk_buff *p,
> > Â Â Â Â Â Â Â Âpreamble = 0;
> > Â Â Â Â Â Â Â Âif (IS_CCK(rspec)) {
> > Â Â Â Â Â Â Â Â Â Â Â Âif (rxh->PhyRxStatus_0 & PRXS0_SHORTH)
> > - Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â WL_ERROR("Short CCK\n");
> > + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â WL_ERROR("%s: Short CCK\n, __func__");
> 
> I have no idea how WL_ERROR works, but are you sure of that?
> 
> You wrote:
> "%s: Short CCK\n, __func__"
> 
> Didn't you mean:
> "%s: Short CCK\n", __func__
> ?
> 

Rafal's suggestion is correct, the patch was incorrect.
(Good eyes, Rafal)

Brett

> --
> RafaÅ

ÿô.nlj·Ÿ®‰­†+%ŠË±é¥Šwÿº{.nlj·¥Š{±ÿ«zW¬³ø¡Ü}©ž²ÆzÚj:+v‰¨þø®w¥þŠàÞ¨è&¢)ß«a¶Úÿûz¹ÞúŽŠÝjÿŠwèf