On Mon, Jan 24, 2011 at 3:27 AM, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > On Mon, 2011-01-24 at 16:36 +0530, aidapalapati@xxxxxxxxxx wrote: > >> A new "rfkill" driver is added to control BT radio. >> A new kernel config variable CONFIG_BT_RFKILL needs to >> be configured to include this driver in the kernel. >> >> Three resources are expected by the driver. >> One Shutdown GPIO, One Reset Gpio and One reference Clock. >> if any/all of the resources can be defined by a platform. > > If that's a generic driver, why can it use > >> + tegra_gpio_enable(bt_rfkill->gpio_reset); > > tegra_* functions? Good catch, I had missed that when I did the initial once-over on the driver. Anantha, the tegra_gpio_enable should be moved to the board setup file and out of the driver itself. -Olof -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
