Hi Greg, I did not retest the suspend/resume change functionally (only compiled it). I decided to do that on v2.6.38-rc1 to be sure and on my system the suspend works. However, upon resume my system reboots without any feedback. System seem to come to live (DVD spinning) and then BIOS boot screen pops up. So I tried suspend/resume without our driver loaded. Results were the same. Also 2.6.37 shows same behaviour. On 2.6.37-rc5 I did not have any issues and suspend/resume worked for our driver and the kernel in general. Anyone else observed such behaviour? Gr. AvS ________________________________________ From: linux-wireless-owner@xxxxxxxxxxxxxxx [linux-wireless-owner@xxxxxxxxxxxxxxx] On Behalf Of Greg KH [greg@xxxxxxxxx] Sent: Thursday, January 20, 2011 9:17 PM To: Arend Van Spriel Cc: gregkh@xxxxxxx; devel@xxxxxxxxxxxxxxxxxxxxxx; linux-wireless@xxxxxxxxxxxxxxx Subject: Re: [PATCH] staging: brcm80211: fix suspend/resume issue in brcmsmac On Wed, Jan 12, 2011 at 06:59:27PM +0100, Arend van Spriel wrote: > PCI PM suspend callback took down the interface and resume brought > it back up. In the mac80211 context this is done in subsequent calls. > Rework implementation so that suspend only stores config, and sets > PCI power state. The resume return to full power state (D0), restores > the config, and brings hardware back up. Full bringup is done by > subsequent mac80211 calls. > > Reviewed-by: Brett Rudley <brudley@xxxxxxxxxxxx> > Signed-off-by: Arend van Spriel <arend@xxxxxxxxxxxx> > --- > drivers/staging/brcm80211/brcmsmac/wl_mac80211.c | 28 ++++++++++++--------- > drivers/staging/brcm80211/brcmsmac/wl_mac80211.h | 4 +-- > 2 files changed, 17 insertions(+), 15 deletions(-) This patch doesn't apply to Linus's tree, which is where it needs to go right now. Can you please redo it so that I can apply it? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
