Stanislaw Gruszka wrote: > Similar fix I already posted for ath9k. When stopping device, disable > interrupts, kill tasklets and then works, in correct order. Patch drop > mutex in them middle of a function, which I don't like and can possibly > not be correct. Perhaps this can be arranged differently. Also > there is no synchronize_irq, which IMHO should be added somewhere in > htc/wmi stop. It should be okay if the work instances are canceled first before the mutex is acquired. And I don't think synchronize_irq() is required since this is a USB driver. But when the driver is loaded and unloaded without bringing the interface up, stop() wouldn't be called at all, but I guess it's alright since no tasklet would have been scheduled. So just moving the tasklet_kill() functions to stop() would be fine. I tested with ath9k_htc and saw no issues. Sujith -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
