On Sun, Jan 16, 2011 at 10:28 AM, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > On Sun, 2011-01-16 at 09:49 +0200, Eliad Peller wrote: > >> @@ -813,7 +813,7 @@ int wl1271_acx_ap_rate_policy(struct wl1271 *wl, struct conf_tx_rate_class *c, >> acx->rate_policy.long_retry_limit = c->long_retry_limit; >> acx->rate_policy.aflags = c->aflags; >> >> - acx->rate_policy_idx = idx; >> + acx->rate_policy_idx = __cpu_to_le32(idx); > > The underscore version doesn't look appropriate at this point or in fact > anywhere in this patch. > > Also, your patch subject and commit log is wrong -- this doesn't just > fix sparse warnings, it fixes actual bugs pointed out by sparse, so > commit log should reflect that. > thanks for your review! i'll send a new version. what is the difference between the normal and underscore version? atomicity? (i didn't find a documentation about it) -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
