On 01/14/2011 10:05 AM, Felix Fietkau wrote:
On 2011-01-14 6:27 PM, greearb@xxxxxxxxxxxxxxx wrote:
diff --git a/drivers/net/wireless/ath/ath9k/ath9k.h b/drivers/net/wireless/ath/ath9k/ath9k.h index 3108699..a2da259 100644 --- a/drivers/net/wireless/ath/ath9k/ath9k.h +++ b/drivers/net/wireless/ath/ath9k/ath9k.h @@ -607,10 +607,15 @@ struct ath_softc { u32 sc_flags; /* SC_OP_* */ u16 ps_flags; /* PS_* */ u16 curtxpow; - u8 nbcnvifs; - u16 nvifs; bool ps_enabled; bool ps_idle; + short nbcnvifs; + short nvifs; + short naps; /* number of APs */ + short nmeshes; + short nstations; + short nwds; + short nadhocs; unsigned long ps_usecount; struct ath_config config;Do we really need all those counters? Wouldn't it be better to iterate over active interfaces instead?
Well, I like the counters. If they ever do not match expected results, it will be a clue that we have bugs in our setup/teardown/change logic. Seems we use counters like this for ath5k with good results, btw.
if (!ieee80211_is_beacon(fc) || - compare_ether_addr(hdr->addr3, common->curbssid)) + compare_ether_addr(hdr->addr3, common->curbssid)) { + /* TODO: This doesn't work well if you have stations + * associated to two different APs because curbssid + * is just the last AP that any of the stations associated + * with. + */ return; + } if (rx_stats->rs_rssi != ATH9K_RSSI_BAD&& !rx_stats->rs_moreaggr) ATH_RSSI_LPF(aphy->last_rssi, rx_stats->rs_rssi);Checking for the STA opmode is correct, this code should not be used for STA+AP. For the multi-STA case, it may make sense to process the RSSI average per vif and using the minimum for ANI.
Ok. I'll leave that alone for now. Thanks, Ben -- Ben Greear <greearb@xxxxxxxxxxxxxxx> Candela Technologies Inc http://www.candelatech.com -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
