On Sun, Jan 09, 2011 at 11:38:21PM +0530, Felix Fietkau wrote: > On 2011-01-09 9:51 AM, Rajkumar Manoharan wrote: > > The commit "ath9k: Add change_interface callback" is > > failed to set hw opmode while changing interface type > > on runtime. Not setting opmode fails to generate > > beacons on changing to AP mode. > > > I think since not only ah->opmode matters, but also various other things > that conditionally enable/disable ANI, various flags in ah->imask, etc. > it would probably be best to merge most of the code of .add_interface, > .remove_interface and .change_interface into one function that iterates > over all active interfaces and calculates all the mode dependent > parameters. The way things are done right now is just too fragile. Sorry for delayed response. Will send a RFC patch. Thanks for the review. -- Rajkumar -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
