Search Linux Wireless

Re: [PATCH v2 2/4] iw: Add channel busy time to survey

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2011-01-11 at 09:51 +0900, Bruno Randolf wrote:
> From: Felix Fietkau <nbd@xxxxxxxxxxx>
> 
> Print channel busy time in survey dump.
> 
> This patch comes from OpenWRT. Original author: Felix Fietkau.
> Fixed up for unsigned values.

I've fixed it up, but two things: You should've lost the "original
author" crap after you fixed up the git author field.

Secondly,

> 
> +               printf("\tchannel receive time:\t\t%llu ms\n",
> +                       (uint64_t)nla_get_u64(sinfo[NL80211_SURVEY_INFO_CHANNEL_TIME_RX]));

caused warnings:
survey.c: In function âprint_survey_handlerâ:
survey.c:55: warning: format â%lluâ expects type âlong long unsigned intâ, but argument 2 has type âuint64_tâ
survey.c:58: warning: format â%lluâ expects type âlong long unsigned intâ, but argument 2 has type âuint64_tâ
survey.c:61: warning: format â%lluâ expects type âlong long unsigned intâ, but argument 2 has type âuint64_tâ
survey.c:64: warning: format â%lluâ expects type âlong long unsigned intâ, but argument 2 has type âuint64_tâ
survey.c:67: warning: format â%lluâ expects type âlong long unsigned intâ, but argument 2 has type âuint64_tâ


because uint64_t isn't guaranteed to be unsigned long long (in fact, it
is unsigned long on many machines). Please look at the commit and check.

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux