Search Linux Wireless

Re: [ath9k-devel] [PATCH v2 3/3] ath9k: Keep track of stations for debugfs.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 01/07/2011 12:12 PM, Luis R. Rodriguez wrote:
On Thu, Jan 06, 2011 at 08:49:12PM -0800, greearb@xxxxxxxxxxxxxxx wrote:
From: Ben Greear<greearb@xxxxxxxxxxxxxxx>

The stations hold the ath_node, which holds the tid
and other xmit logic structures.  In order to debug
stuck xmit logic, we need a way to print out the tid
state for the stations.

Signed-off-by: Ben Greear<greearb@xxxxxxxxxxxxxxx>
---

v1 ->  v2:  Use linked list instead of array.  Protect with spinlock.

Again, see my comments about the # STAs limit. I think this can go in
as a cfg80211 driver limitation which can be exposed. If you want to go
over the supported number (known to work, safe, call it what you want)
then a kconfig option can be used.

Either way, it's a separate patch.

The last thing I want to do is to make it harder to reproduce bugs,
so if 60 causes issues, and we made the default limit to 32,
then it just makes it that much harder for someone to reproduce
bugs and fix them (twiddle kconfig, re-compile kernel, etc).

I surely can't stop you from putting in a similar patch, but
I'm going to focus my own efforts on fixing problems I've already
found.

Thanks,
Ben


   Luis


--
Ben Greear <greearb@xxxxxxxxxxxxxxx>
Candela Technologies Inc  http://www.candelatech.com
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux