Search Linux Wireless

Re: [RFC v2] cfg80211: Add HT BSS attributes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jan 6, 2011 at 12:28 AM, Sujith <m.sujith@xxxxxxxxx> wrote:
> From: Sujith Manoharan <Sujith.Manoharan@xxxxxxxxxxx>
>
> Add two new per-BSS attributes to allow configuration of
> HT capabilites and operational parameters by hostapd.
>
> Signed-off-by: Sujith Manoharan <Sujith.Manoharan@xxxxxxxxxxx>
> ---
> v2: Initialize values and set the parameters in managed mode also.

Can you split this up into two patches, one for cfg80211 and another
for mac80211?

> diff --git a/net/mac80211/cfg.c b/net/mac80211/cfg.c
> index 4bc8a92..f10c92b 100644
> --- a/net/mac80211/cfg.c
> +++ b/net/mac80211/cfg.c
> @@ -1172,6 +1172,21 @@ static int ieee80211_change_bss(struct wiphy *wiphy,
> Â Â Â Â Â Â Â Âchanged |= BSS_CHANGED_HT;
> Â Â Â Â}
>
> + Â Â Â if (params->ht_capab >= 0) {
> + Â Â Â Â Â Â Â struct ieee80211_local *local = wiphy_priv(wiphy);
> + Â Â Â Â Â Â Â struct ieee80211_supported_band *sband =
> + Â Â Â Â Â Â Â Â Â Â Â wiphy->bands[local->oper_channel->band];
> +
> + Â Â Â Â Â Â Â sdata->vif.bss_conf.ht_capab =
> + Â Â Â Â Â Â Â Â Â Â Â (u16) (params->ht_capab & sband->ht_cap.cap);
> + Â Â Â Â Â Â Â changed |= BSS_CHANGED_HT;
> + Â Â Â }
> +
> + Â Â Â if (params->ht_param >= 0) {
> + Â Â Â Â Â Â Â sdata->vif.bss_conf.ht_param = (u8) params->ht_param;
> + Â Â Â Â Â Â Â changed |= BSS_CHANGED_HT;
> + Â Â Â }
> +

Also, if the values do not change why insist on the BSS_CHANGED_HT ?

  Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux