On Fri, 2010-12-31 at 01:29 +0200, Winkler, Tomas wrote: > > > -----Original Message----- > > From: Stephen Hemminger [mailto:stephen.hemminger@xxxxxxxxxx] > > Sent: Friday, December 31, 2010 1:06 AM > > To: Winkler, Tomas; Stephen Hemminger; Johannes Berg > > Cc: davem@xxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx ; linux- > > wireless@xxxxxxxxxxxxxxx > > Subject: RE: [PATCH net-2.6] bridge: fix br_multicast_ipv6_rcv for paged > > skbs > > > > Although copy is slower for large packets, this is a non performance path. > > The code in question is for bridged multicast Ipv6 ICMP packets. This case > > is so uncritical it could be done in BASIC and no one could possibly care! > > > > > Fair enough, although you got few of those when you connect to win7 client. > Anyhow my fix would work if the second pull would be > if (!pskb_may_pull(skb2, sizeof(struct mld_msg))) instead of (!pskb_may_pull(skb2, sizeof(*icmp6h))) I don't think that works either since that may be longer than the entire skb's length since the payload still is variable at this point. johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
