On Sun, Dec 26, 2010 at 8:35 PM, Rafael J. Wysocki <rjw@xxxxxxx> wrote: > On Sunday, December 26, 2010, Ohad Ben-Cohen wrote: >> On Sun, Dec 26, 2010 at 1:45 PM, Rafael J. Wysocki <rjw@xxxxxxx> wrote: >> > Why does the driver need the device to be reset even though it hasn't >> > been suspeneded yet? >> >> Because it is asked to stop the hardware by mac80211. > > So I guess the mac80211 layer should ask it to start it again. It does... And at this point the driver will try to boot a new firmware, but it will only succeed if the device was indeed powered off. If it wasn't (system suspend was cancelled before the host controller suspended), the driver will fail to resume the device (because it can't reset it). We can change man80211 to let us know the system is suspending, and then we will power down the device directly. Or we can use something like your "runtime only" proposal, and then pm_runtime_put_sync() will just work for us regardless of the system state. But that will not solve the /sys/devices/.../power/control problem. For that we will either have always to bypass runtime PM, or introduce something like "always auto"... Thanks, Ohad. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
