On Thu, Dec 23, 2010 at 07:25:42AM +0530, Senthilkumar Balasubramanian wrote: > On Wed, Dec 22, 2010 at 09:22:06PM +0530, Luis R. Rodriguez wrote: > > On Wed, Dec 22, 2010 at 10:44 AM, Senthil Balasubramanian > > <senthilkumar@xxxxxxxxxxx> wrote: > > > There are few places where we are checking for macversion and revsions > > > before RTC is powered ON. However we are reading the macversion and > > > revisions only after RTC is powered ON and so both macversion and > > > revisions are actully zero and this leads to incorrect srev checks > > > > > > Incorrect srev checks can cause registers to be configured wrongly and can > > > cause unexpected behavior. Fixing this seems to address the ASPM issue that > > > we have observed. The laptop becomes very slow and hangs mostly with ASPM L1 > > > enabled without this fix. > > > > On what chipset? Or did we see this on one chipset and suspect it can > > affect others? > We have noticed on Merlin and it is obviously incorrect for other chipsets This should be read as "we have noticed this issue with ar9380/ar9382" > also :-(. Please feel free to rephrase/rework on this patch if you think > something is still lacking/missing... > > > > Luis -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html