On Wed, Dec 22, 2010 at 12:22:21PM -0500, Luis R. Rodriguez wrote: > On Wed, Dec 22, 2010 at 12:21 PM, Luis R. Rodriguez <mcgrof@xxxxxxxxx> wrote: > > On Wed, Dec 22, 2010 at 11:47 AM, Hauke Mehrtens <hauke@xxxxxxxxxx> wrote: > >> On 12/22/2010 05:13 PM, Luis R. Rodriguez wrote: > >>> On Wed, Dec 22, 2010 at 11:09 AM, Elvis Dowson <elvis.dowson@xxxxxxx> wrote: > >>>> netdev_alloc_skb_ip_align > >>> > >>> I notice you have an android kernel, is that kernel a vanilla kernel > >>> or did it get netdev_alloc_skb_ip_align() cherry picked into it? > >>> > >>> Luis > >> > >> netdev_alloc_skb_ip_align is not defined in the 2.6.32.27 vanilla > >> kernel. Someone else (google or ti) must have backported it to this > >> kernel and added it to your kernel. > >> > >> I do not want to add some special handling into compat-wireless just for > >> some android kernel. Just remove netdev_alloc_skb_ip_align() and > >> NETDEV_POST_INIT from include/linux/compat-2.6.33.h and the compile > >> problems you posted should be fixed. > > > > Well we did something to accommodate RHEL, I wouldn't mind supporting > > some fudge for Android so long as someone is willing to submit the > > patch and identify the kernel properly. Android is popular enough and > > I rather reduce the time it takes to use it there than to create an > > extra hurdle. > > Now that I think about it I don't think John ever respinned his > patches for compat-wireless for RHEL. No, I didn't. Johannes wanted some sort of API level indicator instead of checking for RHEL kernels, but I have no idea how to implement that. FWIW, I'd rather you just take the patches I submitted and any similar patches for other Enterprise-y distros (including Android). But if someone else can demonstrate a workable, better alternative then I will try to comply. John -- John W. Linville Someday the world will need a hero, and you linville@xxxxxxxxxxxxx might be all we have. Be ready. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
