On Wed, Dec 22, 2010 at 9:02 AM, Johannes Berg
<johannes@xxxxxxxxxxxxxxxx> wrote:
> On Mon, 2010-12-20 at 12:02 -0500, Luis R. Rodriguez wrote:
>
>> --- a/include/linux/nl80211.h
>> +++ b/include/linux/nl80211.h
>> @@ -858,6 +858,9 @@ enum nl80211_commands {
>> Â * Â attributes, specifying what a key should be set as default as.
>> Â * Â See &enum nl80211_key_default_types.
>> Â *
>> + * @NL80211_ATTR_REG_COUNTRY_FLAGS: Country specific regulatory flags.
>> + * Â These are @NL80211_CFLAG_DFS_*
>> + *
>
> Please also add a note "(u16)" here or so.
Sure.
>> +#define flag_check_print(_str) \
>> + Â Â do { \
>> + Â Â Â Â Â Â if (has_flag) \
>> + Â Â Â Â Â Â Â Â Â Â pr_info(", "); \
>> + Â Â Â Â Â Â pr_info(_str); \
>> + Â Â Â Â Â Â has_flag = true; \
>> + Â Â } while (0)
>> +
>> +static void print_country_flags(u16 flags)
>> +{
>
> Can you move the define into the function, and also #undef it please?
OK
> Also -- it seems that this is never reported back to be printed by iw
> reg get?
Actually it is. See the changes on nl80211_get_reg(), and I tested
this and I get it.
> I think that might be needed?
Yeap.
> If you do, it should only report
> the ones that the kernel knows about (i.e. mask them with the _ALL
> thing)
Sure.
> Does it make sense to actually have this a bitmask rather than an enum?
Good question.
> Do we think there's some place that needs _multiple_ rules?
Good question, I have my call with Michael scheduled for 11am PST
time, hope to get some insight into his regulatory crystal ball then.
Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
