Hi Stanislaw,
On Tue, 2010-12-21 at 04:05 -0800, Stanislaw Gruszka wrote:
> Hi Wey
>
> On Mon, Dec 20, 2010 at 10:13:36AM -0800, Guy, Wey-Yi wrote:
> > On Mon, 2010-12-20 at 09:05 -0800, Stanislaw Gruszka wrote:
> > > Looks that we do not set correctly antennas when scanning
> > > on 5Ghz band and when bluetooth is enabled, because
> > > priv->cfg->scan_tx_antennas[band] is only defined for
> > > IEEE80211_BAND_2GHZ. This fix choose first valid antenna.
> > >
> > > Signed-off-by: Stanislaw Gruszka <sgruszka@xxxxxxxxxx>
> > > ---
> > > drivers/net/wireless/iwlwifi/iwl-agn-lib.c | 3 +--
> > > 1 files changed, 1 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/net/wireless/iwlwifi/iwl-agn-lib.c b/drivers/net/wireless/iwlwifi/iwl-agn-lib.c
> > > index 4bc82fc..099039c 100644
> > > --- a/drivers/net/wireless/iwlwifi/iwl-agn-lib.c
> > > +++ b/drivers/net/wireless/iwlwifi/iwl-agn-lib.c
> > > @@ -1499,8 +1499,7 @@ int iwlagn_request_scan(struct iwl_priv *priv, struct ieee80211_vif *vif)
> > > priv->cfg->bt_params->advanced_bt_coexist &&
> > > priv->bt_full_concurrent) {
> > > /* operated as 1x1 in full concurrency mode */
> > > - scan_tx_antennas = first_antenna(
> > > - priv->cfg->scan_tx_antennas[band]);
> > > + scan_tx_antennas = first_antenna(scan_tx_antennas);
> >
> > If its is 2.4, we need to use the correct tx antenna, I think we can
> > remove this block of code all together since check already done above.
> >
> > if (priv->cfg->scan_tx_antennas[band])
> > scan_tx_antennas = priv->cfg->scan_tx_antennas[band];
>
> Is correct to use all antennas on 5GHz when blutooth is enabled?
> For me, more logical would be limiting to one antenna no matter of band,
> since antennas are used anyway, only frequencies differ.
>
> For rx_ant, we do not check the band, only limit to first one
> when bluetooth is used.
there is no BT coex if 5GHz is used because there is not interference
between 2.4 and 5GHz, so both antenna can be used. WiFi should operated
in normal condition.
For 2.4GHz, we also can use both antenna if there is not high traffic
load on BT side.
but you have a good catch, driver need to check band before use it
(scan_tx_antenna[band])
Thanks
Wey
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
