Search Linux Wireless

Re: [PATCH 2/4] b43: N-PHY: implement radio 2056 init steps

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



W dniu 21 grudnia 2010 12:34 uÅytkownik Michael BÃsch <mb@xxxxxxxxx> napisaÅ:
> On Tue, 2010-12-21 at 11:50 +0100, RafaÅ MiÅecki wrote:
>> +static void b43_radio_init2056_post(struct b43_wldev *dev)
>> +{
>> + Â Â b43_radio_set(dev, B2056_SYN_COM_CTRL, 0xB);
>> + Â Â b43_radio_set(dev, B2056_SYN_COM_PU, 0x2);
>> + Â Â b43_radio_set(dev, B2056_SYN_COM_RESET, 0x2);
>> + Â Â mdelay(1);
>
> Please don't use mdelay() ever. The driver is fully preemptible.
> Use msleep() instead.

So, using "msleep" allows kernel to switch context, while using
"mdelay" does not?

If so, should be convert our longer udelay calls (like 300us) to usleep?

-- 
RafaÅ
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux