On Mon, Dec 20, 2010 at 02:00:41PM +0530, Dan Carpenter wrote:
> Hello Vasanthakumar,
>
> Smatch complains that in linux-next 60e0c3a7 "ath9k_hw: Eeeprom changes
> for AR9485" means there is a potential read past the end of the buffer
> int ar9300_eeprom_restore_internal().
>
> drivers/net/wireless/ath/ath9k/ar9003_eeprom.c +3381
> ar9300_eeprom_restore_internal(81)
> error: buffer overflow 'word' 2048 <= 4099
>
> "word" is allocated with 2048 bytes:
> word = kzalloc(2048, GFP_KERNEL);
>
> "length" can be up to 4099:
> if ((!AR_SREV_9485(ah) && length >= 1024) ||
> (AR_SREV_9485(ah) && length >= (4 * 1024))) {
Yeah, this looks buggy, the eeprom data length for AR9485 is 1088
bytes only, I'll send out a patch, thanks for reporting this.
Vasanth
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
