Hello, On 12/17/2010 04:45 AM, Larry Finger wrote: > On 12/16/2010 01:59 PM, John W. Linville wrote: >> create_workqueue is deprecated. The workqueue usage does not seem to >> demand any special treatment, so do not set any flags either. >> >> Signed-off-by: John W. Linville <linville@xxxxxxxxxxxxx> >> --- >> I don't have the hardware to test... > > Hold off on this one. It seems to break the driver, but I do not > know why just yet. There are two differences between create_workqueue(name) and alloc_workqueue(name, 0, 0). * The former has WQ_MEM_RECLAIM set and forward progress is guaranteed regardless of memory pressure. In this case, this shouldn't make any difference. * The former has @max_active set to 1 while the latter to WQ_DFL_ACTIVE. IOW, works queued on the same CPU would be allowed to run concurrently while before conversion only different CPUs can run works queued to the workqueue in parallel. This usually shouldn't make difference either as works could have run in parallel on different CPUs before too. Does alloc_workqueue(name, 0, 1) fix the problem? If so, it might be that the current workqueue usage has problem too. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
