On 12/15/2010 10:37 AM, John W. Linville wrote: > On Wed, Dec 15, 2010 at 05:26:40PM +0100, Johannes Berg wrote: > >>> If you prefer that it go to staging first, I will send it to GregKH, but since >>> it uses mac80211, I think it is ready for wireless. >> >> It looks pretty clean -- so personally, I don't think I'd mind it going >> in directly. >> >> Are you or somebody else planning to make changes to it though? It looks >> like for example the config semaphore could easily be replaced by a >> mutex for better debug, for example. Potentially, rate control could be >> internalised with IEEE80211_HW_HAS_RATE_CONTROL as well, and some >> similar minor things. Certainly, the semaphore can be replaced with a mutex. I will need to think about the rate control. > > Sorry for the delay, Larry! I've been meaning to post a thorough > review, but...busy, busy... > > Anyway, I think Johannes is right -- whatever issues remain, it > would be better to get it in place now than to leave it out or push > it to staging. > > I intend to mash the series together into a single patch when I merge > it -- I hope you don't mind. No, I don't mind. I just put it as multiple patches for review. One nice thing about being retired is that I don't have to deal with any bean counters who might worry about number or lines of patches - only making Linux better. If you want, I can make it a single patch and put it in the git tree I mentioned for you to pull. Larry -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
